Comment|DowntimeDetail: Use correct filter for removal #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #1060, comments/delete and downtimes/delete try to use `ObjectAuthorization`'s cache properly and override `CommandAction`'s `isGrantedOnType()`. Though, the filter is applied to the host and service model as a result, and not to the downtime model. This way, downtime filters MUST be absolute, just like filters provided by the search bar. Otherwise `name=downtime-name` will be translated to e.g. `host.name=downtime-name` which obviously cannot match. fixes #1245
nilmerg
added
bug
|
@sukhwinder33445 Note that you need to be restricted to reproduce the issue. |
sukhwinder33445
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1060, comments/delete and downtimes/delete try to use
ObjectAuthorization's cache properly and overrideCommandAction'sisGrantedOnType(). Though, the filter is applied to the host and service model as a result, and not to the downtime model. This way, downtime filters MUST be absolute, just like filters provided by the search bar. Otherwisename=downtime-namewill be translated to e.g.host.name=downtime-namewhich obviously cannot match.fixes #1245