Skip to content

ObjectSuggestions: Prioritze Column suggestions and best suggestions #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

raviks789
Copy link
Contributor

Show custom variable suggestions only if the column suggestions have not consumed all the slots (50).

fixes #1206

@raviks789 raviks789 self-assigned this Jun 11, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jun 11, 2025
@raviks789 raviks789 force-pushed the fix/suggestions-responsiveness branch 3 times, most recently from 781bfaf to cc6c809 Compare June 11, 2025 14:41
@raviks789 raviks789 requested a review from nilmerg June 11, 2025 14:44
@raviks789 raviks789 requested a review from nilmerg June 12, 2025 08:06
Show custom variable suggestions only if the column suggestions have not consumed all the
slots (50).
@raviks789 raviks789 force-pushed the fix/suggestions-responsiveness branch from 2c0aa6e to cd25882 Compare June 13, 2025 08:12
@raviks789 raviks789 force-pushed the fix/suggestions-responsiveness branch 2 times, most recently from 2153fd3 to f3109ed Compare June 13, 2025 10:57
@raviks789 raviks789 force-pushed the fix/suggestions-responsiveness branch from f3109ed to 52f9537 Compare June 13, 2025 10:59
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to replace the in_array search with a database filter!

@nilmerg nilmerg merged commit d0ffba3 into main Jun 13, 2025
10 checks passed
@nilmerg nilmerg deleted the fix/suggestions-responsiveness branch June 13, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore suggestion responsiveness
2 participants