CritIfNotMatch tries to convert strings to decimal if the string contains a colon

[moreamazingnick]

I came across an unusual behavior updating the framework from 1.9 to 1.13.*

The Check engine tries to convert a threshold string into a decimal if the string contains a colon even if a match function is used and the perf data generation is disabled.

$Check = New-IcingaCheck -Name "Check" -Value "testa" -NoPerfData;
$Check.CritIfNotMatch("testb:testc") | Out-Null;
New-IcingaCheckresult -Check $Check  -Compile

return:

[UNKNOWN] Check: Der Wert "testb" kann nicht in den Typ "System.Decimal" konvertiert werden. Fehler: "Die Eingabezeichenfolge hat das falsche Format."
3

Best Regards
Nicolas

[LordHepipud]

Thanks for the issue. It seems the check engine is interpreting this as a range and fails afterwards, because obviously this is wrong.

I will have a look on that. For match comparisons there shouldn't be a threshold conversion happening.

[drapiti]

Just to add to this in general the problem is occurring with special characters not just colons. CritIfNotLike calls Compare-IcingaPluginThresholds with -NotMatches $TRUE
CritIfNotMatch also calls Compare-IcingaPluginThresholds but through CritIfNotLike

The issue is that both CritIfNotMatch and CritIfNotLike ultimately call the same Compare-IcingaPluginThresholds function, which is trying to do some kind of conversion that's failing on special characters.