Define hasqns
, delete dag
in favor of GradedUnitRanges.dag
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ITensor/GradedUnitRanges.jl#11,
dag
is now defined inGradedUnitRanges.dag
. I'm taking an approach with this package that we only define what is strictly necessary here, and offload as much as possible to other packages, so I'm deleting the definition from here (and anyway, the previous definition was a placeholder that was incorrect for symmetric tensors).Also, I've properly defined
hasqns
, though probably we want to deprecate it and come up with a different name/concept that is defined in GradedUnitRanges.jl, maybe calledisgraded
. But that can be discussed later.