Skip to content

Define hasqns, delete dag in favor of GradedUnitRanges.dag #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

mtfishman
Copy link
Member

As of ITensor/GradedUnitRanges.jl#11, dag is now defined in GradedUnitRanges.dag. I'm taking an approach with this package that we only define what is strictly necessary here, and offload as much as possible to other packages, so I'm deleting the definition from here (and anyway, the previous definition was a placeholder that was incorrect for symmetric tensors).

Also, I've properly defined hasqns, though probably we want to deprecate it and come up with a different name/concept that is defined in GradedUnitRanges.jl, maybe called isgraded. But that can be discussed later.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.27%. Comparing base (7a1ed53) to head (584e3cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   48.08%   50.27%   +2.18%     
==========================================
  Files           6        7       +1     
  Lines         183      183              
==========================================
+ Hits           88       92       +4     
+ Misses         95       91       -4     
Flag Coverage Δ
docs 23.07% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit 848f01e into main Feb 6, 2025
12 checks passed
@mtfishman mtfishman deleted the dag branch February 6, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants