Skip to content

review: style: change set to enumset #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2022
Merged

review: style: change set to enumset #4940

merged 1 commit into from
Oct 9, 2022

Conversation

MartinWitt
Copy link
Collaborator

@MartinWitt MartinWitt commented Sep 30, 2022 •
edited
Loading

Enumset for enum values is strictly better than set, and this fixes one of many locations with this bad smell.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Sep 30, 2022

⚠️ 85 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@MartinWitt MartinWitt changed the title style: change set to enumset review: style: change set to enumset Oct 3, 2022
slarse
slarse approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, that return statement is a mouthful. But I suppose what you did here makes it ever so slightly better.

@slarse slarse merged commit 539322b into master Oct 9, 2022
@slarse slarse deleted the fluttering-asp branch October 9, 2022 18:44
@SirYwell SirYwell mentioned this pull request Oct 12, 2022
Closed
@MartinWitt MartinWitt mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@slarse slarse slarse approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinWitt @slarse