Skip to content

feat(type): Uses CtTypeAccess for static field read / field write / calls. #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2016
Merged

feat(type): Uses CtTypeAccess for static field read / field write / calls. #475

merged 3 commits into from
Jan 18, 2016

Conversation

GerardPaligot
Copy link
Contributor

Closes #346
Closes #476

monperrus
monperrus reviewed Jan 7, 2016
View reviewed changes
src/test/java/spoon/test/targeted/TargetedExpressionTest.java Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an assert for the getTarget of the 3 field writes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@GerardPaligot
Copy link
Contributor Author

@monperrus PR ok for me.

@monperrus monperrus changed the title feat(type): Uses CtTypeAccess for static field. feat(type): Uses CtTypeAccess for static field read / field write / calls. Jan 8, 2016
@GerardPaligot GerardPaligot changed the title feat(type): Uses CtTypeAccess for static field read / field write / calls. WIP feat(type): Uses CtTypeAccess for static field read / field write / calls. Jan 14, 2016
@GerardPaligot
Copy link
Contributor Author

Adds javadoc in CtTargetedExpression : getTarget returns never null and add some samples.

@GerardPaligot GerardPaligot changed the title WIP feat(type): Uses CtTypeAccess for static field read / field write / calls. feat(type): Uses CtTypeAccess for static field read / field write / calls. Jan 15, 2016
monperrus added a commit that referenced this pull request Jan 18, 2016
@monperrus
Merge pull request #475 from GerardPaligot/test_static_field
55d477d
@monperrus monperrus merged commit 55d477d into INRIA:master Jan 18, 2016
@GerardPaligot GerardPaligot deleted the test_static_field branch January 18, 2016 12:32
@GerardPaligot GerardPaligot mentioned this pull request Jan 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GerardPaligot @monperrus