fix: add for-loop elements to UnsupportedElementSwapper and add warning messages (issue #4716) #4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkforsb Would we able to add a test case to specify this behavior? |
Two simple tests added. |
|
Could you document the current implementation state inside the subproject? Missing elements are a factory when you choose your tool, and we should be as honest as possible about the limitations. |
|
@MartinWitt the reference doc is Mikael Forsberg's master's thesis "Design and Implementation of Semantic Patch Support for the Spoon Java Transformation Engine' at KTH Royal Institute of Technology". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
CtForandCtForEachto the set of elements swapped out by spoon-smpl'sUnsupportedElementSwapperalong with a warning log message for each replaced element.Should be a slight improvement on the current user experience (see #4716).