review: Fix NPE with union catch inside lambda in noclasspath #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
commented
Jun 23, 2017
| @Test | ||
| public void testUnionCatchExceptionInsideLambdaInNoClasspath() { | ||
| // contract: the model should be built when defining a union catch inside a lambda which is not known (noclasspath) | ||
| // and the catch variable should be the same than outside a lambda |
There was a problem hiding this comment.
I added this contract which seems reasonable, but I have problem to achieve this second part of the contract (and so, the last equals is a wrong assertion): JDT does not provide any information about the exception type inside the lambda, even not the fully qualified name of the exception. As a result, I have only the simple name of the class, which does not allow me easily to infer any information like on any other case.
So, do you have any idea how to improve that, or could we remove this part of the contract and consider that in this specific case the model have less information?
surli
changed the title
surli
pushed a commit
that referenced
this pull request
Jul 30, 2018
* refactor: remove commented code * refactor: remove comment - it is fixed in #1416 * refactor: remove commented code * fix typo * restore deleted assertion
spoon-bot
added a commit
to SpoonLabs/spoon-ci-data
that referenced
this pull request
Jul 30, 2018
* refactor: remove commented code * refactor: remove comment - it is fixed in INRIA/spoon#1416 * refactor: remove commented code * fix typo * restore deleted assertion
spoon-bot
added a commit
to SpoonLabs/spoon-ci-data
that referenced
this pull request
Jul 30, 2018
* refactor: remove commented code * refactor: remove comment - it is fixed in INRIA/spoon#1416 * refactor: remove commented code * fix typo * restore deleted assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a NPE we had when spooning a catch with multi exception inside a lambda in no classpath mode, as explained in #1415.
However the bug is not completely solved in that PR, in that sense that the model is not exactly the same as if the try catch was outside the lambda. I decided to concentrate on getting information from multi types (which was causing the NPE). But to complete it, we should also compute the type of CtCatchVariable from the multitypes (it's normally done by JDT). I opened an issue for that and I propose to solve it in a separate PR (see #1420)