Skip to content

Conversation

monperrus
Copy link
Collaborator

The great Spoon community keeps growing, and we need to explain how to recognize a top-contributor as integrator.

What do you think of this?

@surli
Copy link
Collaborator

surli commented Jun 26, 2017

It's ok for me.

CONTRIBUTING.md Outdated
* One only merges atomic pull requests (single bug fix or single feature)
* One only merges well tested and well documented pull requests, after thorough code review
* One never merges one's own pull request
* One leaves pull requests opened at least 1 day before merging, so that the community is aware and can comment on them
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monperrus monperrus force-pushed the community-integrator-rules branch from 9cbdda4 to 948c161 Compare June 26, 2017 15:13
@tdurieux
Copy link
Collaborator

Ok for me

@monperrus monperrus force-pushed the community-integrator-rules branch from 948c161 to d55cab4 Compare June 26, 2017 15:14
@monperrus monperrus force-pushed the community-integrator-rules branch from d55cab4 to 75bf584 Compare June 26, 2017 16:47
@surli
Copy link
Collaborator

surli commented Jun 28, 2017

@danglotb do you agree?

@danglotb
Copy link
Collaborator

I do

@monperrus
Copy link
Collaborator Author

all integrators agree, we can proceed with merge @surli?

@surli surli merged commit 6551346 into INRIA:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants