Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

fix(scss): switch fixed rows to minmax for dynamic content #6

Merged
merged 1 commit into from
Jan 24, 2018
Merged

fix(scss): switch fixed rows to minmax for dynamic content #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/src/scss/_core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ body {
@include gridLegacyWrapper($includeFlexFallback) {
@include gridColumns($breakpoint, $first, $last) {
display: grid;
grid-auto-rows: $rowHeight * 1rem;
grid-auto-rows: minmax($rowHeight * 1rem, min-content);
}
@include gridVariables($breakpoint, $first, $rows, $rowHeight);
}
Expand Down
Binary file modified examples/bootstrap/css-gridish/bootstrap-grid.sketch
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion examples/bootstrap/css-gridish/css/bootstrap-grid-legacy.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ body {
@supports (display: grid) {
.bootstrap-grid {
display: grid;
grid-auto-rows: 1rem;
grid-auto-rows: minmax(1rem, min-content);
grid-template-columns: repeat(auto-fill, 8.33333vw); }
.bootstrap-grid.bootstrap-grid--fixed-columns {
grid-template-columns: repeat(auto-fill, 3rem); }
Expand Down
2 changes: 1 addition & 1 deletion examples/bootstrap/css-gridish/css/bootstrap-grid-legacy.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/bootstrap/css-gridish/css/bootstrap-grid.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ body {

.bootstrap-grid {
display: grid;
grid-auto-rows: 1rem;
grid-auto-rows: minmax(1rem, min-content);
grid-template-columns: repeat(auto-fill, 8.33333vw); }
.bootstrap-grid.bootstrap-grid--fixed-columns {
grid-template-columns: repeat(auto-fill, 3rem); }
Expand Down
2 changes: 1 addition & 1 deletion examples/bootstrap/css-gridish/css/bootstrap-grid.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/bootstrap/css-gridish/scss/_core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ body {
@include gridLegacyWrapper($includeFlexFallback) {
@include gridColumns($breakpoint, $first, $last) {
display: grid;
grid-auto-rows: $rowHeight * 1rem;
grid-auto-rows: minmax($rowHeight * 1rem, min-content);
}
@include gridVariables($breakpoint, $first, $rows, $rowHeight);
}
Expand Down
Binary file modified examples/carbon/css-gridish/bx-grid.sketch
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion examples/carbon/css-gridish/css/bx-grid-legacy.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ body {
@supports (display: grid) {
.bx-grid {
display: grid;
grid-auto-rows: 0.5rem;
grid-auto-rows: minmax(0.5rem, min-content);
grid-template-columns: repeat(auto-fill, calc(8.33333vw - 0.83333vw)); }
.bx-grid.bx-grid--fixed-columns {
grid-template-columns: repeat(auto-fill, 1.66667rem); }
Expand Down
Loading