Fix bug where MSVC linker flags were not handled properly #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camio
force-pushed
the
fix-ldflags-msvc
branch
from
ff810c6 to
2c66326
Compare
Clang and GCC's `-Wl` argument can be used to pass arguments to the linker. MSVC, however, does not recognize this option and instead uses a /link flag at the end of all other arguments for this purpose. This commit makes use of "/link" with MSVC when LDFLAGS are used.
camio
force-pushed
the
fix-ldflags-msvc
branch
from
2c66326 to
1e9aa1a
Compare
Hywan
approved these changes
Oct 7, 2024
|
I've reverted the PR as the CI is failing, see #25 |
|
Fixed in #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang and GCC's
-Wlargument can be used to pass arguments to the linker.MSVC, however, does not recognize this option and instead uses a
/link flag at the end of all other arguments for this purpose. This commit
makes use of "/link" with MSVC when LDFLAGS are used.
A test was added that verifies this functionality by setting the
executable's stack size and verifying the change from the generated
executable.
Fixes #8