Skip to content

Conversation

@Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Sep 14, 2025

Automatically update pinned dependencies

@Liam-DeVoe
Copy link
Member

Liam-DeVoe commented Sep 14, 2025

I'm inclined to disable RUF043, because while I do like enforcing the r prefix for regex matches, I think "BadStateMachine\\.initialize has been decorated with both @initialize " is substantially less readable with the backslashes, and not meaningfully more powerful.

@Zac-HD
Copy link
Member Author

Zac-HD commented Sep 16, 2025

Hmm, I think I'm inclined to keep RUF043 enabled - we can re.escape(...) that kind of message, and istm that matches being written as literals then treated as patterns is exactly the sweet spot for a lint rule.

@Liam-DeVoe
Copy link
Member

I don't particularly like the extra indentation from wrapping with re.escape either! The number of tests this affects is pretty limited though so I don't feel strongly against enabling it.

@Zac-HD Zac-HD merged commit 5929385 into master Sep 18, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants