Update install.sh #963
Merged
Update install.sh #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support ARM
MikeMcQuaid
reviewed
Apr 1, 2025
MikeMcQuaid
approved these changes
Apr 1, 2025
|
I think this is reasonable to allow now. Thanks @eifrah-aws! CC @kvokka FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current
install.shscript, any attempt to install brew for Linux onaarch64machines will result in an error. This small fix removes the check and allows brew to be installed.Tested on ubuntu 24.04 aarch64. I was also able to install various tools from Google (like grpc, protobuf, googletest and others).
It might not work well as it does for Intel x86, but it is better than the current alternative
Hope this fix will go through!
CC Homebrew/brew#19208