install.sh: ignore curl snap if found #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snap upstream [refuses to relax strict security confinement](https://forum.snapcraft.io/t/classic-confinement-request-for-curl/24611/13) on curl. This breaks the install process, as at least two different reports reveal: Homebrew#840 https://github.com/orgs/Homebrew/discussions/5776#discussioncomment-11427538
|
Looks like the Windows runner needs to be restarted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snap upstream refuses to relax strict security confinement on curl. This breaks the install process, as at least two different reports reveal: #840 https://github.com/orgs/Homebrew/discussions/5776#discussioncomment-11427538
This patch also warns the user about this rejection, because the curl snap is quite likely the only curl installed on a user's system and is otherwise recent enough to pass the version test, so it provides the necessary clarification to the next thing the user sees: