Add flag to allow root install #1022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emma-Fitzmaurice
force-pushed
the
force-root-install
branch
from
cb2c928 to
8ab4ae5
Compare
|
Passing on this, sorry. The calls to Homebrew itself within this script will fail when run under root too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to allow the script to run as root.
check_run_command_as_root() already makes some exceptions to allow for running as root, but it's non-exhaustive so I think it is reasonable to allow for an override flag.
Sorry if this has been considered and rejected before, i couldn't find anything to that effect