install.sh: improve POSIX compatibility #1013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirsz-ever
force-pushed
the
chirsz/posix-compatibility-250729
branch
2 times, most recently
from
abc8312 to
9f38d5d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves POSIX compatibility in the uninstall.sh script by replacing the non-POSIX -lname option in the find command with a POSIX-compatible alternative using -exec and shell commands.
- Replaces
findcommand's-lnameoption with-execand shell command to maintain the same functionality while ensuring POSIX compatibility
POSIX `find` do not support `-lname`: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/find.html
chirsz-ever
force-pushed
the
chirsz/posix-compatibility-250729
branch
from
9f38d5d to
be5d14d
Compare
MikeMcQuaid
requested changes
Jul 29, 2025
There was a problem hiding this comment.
This is significantly less readable. I don't think it's worthwhile to have a bunch of these PRs trying to fix Busybox bit by bit, sorry. If you can open one that entirely fixes it and add a new GitHub Actions target to ensure it doesn't regress, we'll consider that (but may still reject it if too invasive).
|
The uninstall script is not used often, and it would be easy to edit it before executing, so this PR is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX
finddo not support-lname: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/find.htmlThe purpose of this #PR is the same as #1010, which is to use the busybox toolchain to run the script.
It seems a bit too complicated and reduces readability. Feel free to close this PR.