node: Add option to build with LibreSSL #8018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node can already be build with Homebrew'd OpenSSL. With this change it's possible to build with Homebrew'd LibreSSL. Building with OpenSSL and LibreSSL is disallowed.
|
Apparently I had mistake somewhere and Node doesn't build with LibreSSL. Closing PR for now. |
|
There exists nodejs/node#9376. Check back this PR when that is merged. |
|
@oherrala I'm afraid we won't include this option even after that as we've standardised on OpenSSL in Homebrew. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Node can already be build with Homebrew'd OpenSSL. With this change it's possible to build with Homebrew'd LibreSSL.
Building with OpenSSL and LibreSSL is disallowed.