macvim 8.2-169 #66828
Closed
macvim 8.2-169 #66828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
lua
chenrui333
previously approved these changes
Dec 13, 2020
|
I'm not sure what the failure on Catalina is about. |
CI building arm64 targets on Catalina? |
|
Macvim's Xcode project sometimes wants to build universal binaries, and we should avoid it. That's what the removed patch was going, and this should be filed as an issue with upstream |
|
Hi, I just made a new release (r169) for MacVim so we should make a new one for that instead. The way MacVim currently prevents building universal binaries is via the This won't allow for non-Rosetta builds on Apple Silicon though. But maybe that's a different fix later. Edit: To be clear, that means the patch isn't necessary with this flag. You don't need to add it back. |
|
@ychin Yay! I'll handle that tonight then. |
pthariensflame
force-pushed
the
patch-1
branch
from
6afedce to
76d6c06
Compare
|
@chenrui333 How does this look now? |
|
I'm pretty sure you want |
ychin
reviewed
Dec 21, 2020
ychin
reviewed
Dec 22, 2020
pthariensflame
force-pushed
the
patch-1
branch
from
a270abd to
b5f335e
Compare
|
@ychin All should be resolved now. |
SMillerDev
reviewed
Dec 22, 2020
5 tasks
pthariensflame
force-pushed
the
patch-1
branch
from
b5f335e to
9d0fc8f
Compare
SMillerDev
approved these changes
Dec 24, 2020
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?See also #66778, which this obviates.