Skip to content

Conversation

Efrat19
Copy link
Contributor

@Efrat19 Efrat19 commented Oct 6, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@Efrat19 Efrat19 mentioned this pull request Oct 6, 2019
5 tasks
@fxcoudert
Copy link
Member

  • This version is tagged as prerelease, which is not acceptable for Homebrew core:

Capture d’écran 2019-10-07 à 00 19 25

  • Please squash all changes into a single commit, with commit message formula x.y.z (new formula)

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Oct 6, 2019
@Efrat19 Efrat19 changed the title arduino-cli 0.5.0-showports (new formula) arduino-cli 0.5.0 (new formula) Oct 7, 2019
@Efrat19
Copy link
Contributor Author

Efrat19 commented Oct 7, 2019

@fxcoudert I downgraded the version and squashed the commits according to your guide

@dawidd6
Copy link
Contributor

dawidd6 commented Oct 7, 2019

One more thing, commit should be named like the PR title: arduino-cli 0.5.0 (new formula).

@Efrat19 Efrat19 changed the title arduino-cli 0.5.0 (new formula) formula arduino-cli_0.5.0 (new formula) Oct 7, 2019
@Efrat19
Copy link
Contributor Author

Efrat19 commented Oct 7, 2019

@dawidd6 I named the commit according to @fxcoudert comment:

Please squash all changes into a single commit, with commit message formula x.y.z (new formula)

now I changed the pr name accordingly.
Is that ok now?

@dawidd6
Copy link
Contributor

dawidd6 commented Oct 7, 2019

Will be ok without the formula at the beginning and without the underscore. Just like the PR title.

@Efrat19 Efrat19 changed the title formula arduino-cli_0.5.0 (new formula) arduino-cli 0.5.0 (new formula) Oct 7, 2019
@dawidd6
Copy link
Contributor

dawidd6 commented Oct 7, 2019

Nice, thanks for your contribution to Homebrew!

@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Oct 7, 2019
@SMillerDev
Copy link
Member

Thanks @Efrat19! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@fxcoudert fxcoudert closed this in cdf88f3 Oct 7, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 7, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants