Skip to content

ruby: disable opportunistic linkage to gmp #43841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

ruby: disable opportunistic linkage to gmp #43841

wants to merge 3 commits into from

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Sep 4, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This has bit us a number of times; let's just disable gmp support explicitly so this doesn't keep happening.

@jonchang jonchang added the ready to merge PR can be merged once CI is green label Sep 4, 2019
@jonchang jonchang closed this in 00fd154 Sep 4, 2019
@jonchang jonchang deleted the ruby-gmp branch September 4, 2019 08:09
@lock lock bot added the outdated PR was locked due to age label Jan 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonchang