flow-cli: revision bump, restore build flags#271321
Conversation
|
Caution Failed to change base branch to |
github-actions
Bot
added
the
go
jribbink
force-pushed
the
flow-cli-restore-makefile
branch
from
0c5ac26 to
2c8696f
Compare
github-actions
Bot
added
the
autosquash
jribbink
force-pushed
the
flow-cli-restore-makefile
branch
from
2c8696f to
637f6ae
Compare
github-actions
Bot
removed
the
autosquash
|
@bevanjkay The current release is broken and affecting our users, so I would like to get this merged as soon as possible 😄. Please let me know if it would be preferred to copy the embedded LILICO_TOKEN & MIXPANEL_TOKEN from the Flow CLI Makefile to this Formula instead, to remove the dependency. |
jribbink
force-pushed
the
flow-cli-restore-makefile
branch
from
637f6ae to
fd90a8d
Compare
jribbink
changed the title
Restore upstream build flags which were implicitly removed with the Makefile build process during the v2.14.3 autobump.
MikeMcQuaid
force-pushed
the
flow-cli-restore-makefile
branch
from
fd90a8d to
35407b5
Compare
MikeMcQuaid
left a comment
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Restored Makefile build. Looks good once 🟢. Thanks @jribbink!
|
Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
github-actions
Bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks all! 🙇 |
|
Sorry for the back and forth here @jribbink - I appreciate you taking the time to get this sorted! |
4 participants
Restore upstream build flags that were removed in the 2.14.3 autobump. The Makefile sets required CGO_CFLAGS and ldflags that the formula needs, so this moves those properties into the Formula instead.