Skip to content

mariadb: Use accurate end-of-life dates #258262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottok wants to merge 3 commits into
base: main
Choose a base branch
from
Open

mariadb: Use accurate end-of-life dates #258262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d07659
mariadb@10.6: Use accurate end-of-life dates
ottok Dec 11, 2025
820e7c2
mariadb@11.4: Use accurate end-of-life dates
ottok Dec 13, 2025
1b79939
mariadb@11.8: Use accurate end-of-life dates
ottok Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Formula/m/mariadb@10.6.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ class MariadbAT106 < Formula

keg_only :versioned_formula

# See: https://mariadb.com/kb/en/changes-improvements-in-mariadb-106/
deprecate! date: "2026-06-01", because: :unsupported
# See: https://mariadb.org/about/#maintenance-policy
deprecate! date: "2026-07-06", because: :unsupported
Comment on lines +31 to +32
Copy link
Copy Markdown
Member

@SMillerDev SMillerDev Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a disable! date for when the software is really EOL.


depends_on "bison" => :build
depends_on "cmake" => :build
Expand Down
5 changes: 3 additions & 2 deletions Formula/m/mariadb@11.4.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ class MariadbAT114 < Formula

keg_only :versioned_formula

# See: https://mariadb.com/kb/en/changes-improvements-in-mariadb-11-4/
# End-of-life on 2029-05-29: https://mariadb.org/about/#maintenance-policy
# From https://mariadb.org/about/#maintenance-policy:
# > For releases up to MariaDB 11.4, the binaries are released for 5 years
# > after the GA date (29 May 2024)
Comment on lines +31 to +33
Copy link
Copy Markdown
Member

@daeho-ro daeho-ro Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much differ, the original is still fine.

deprecate! date: "2029-05-29", because: :unsupported

depends_on "bison" => :build
Expand Down
7 changes: 5 additions & 2 deletions Formula/m/mariadb@11.8.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ class MariadbAT118 < Formula

keg_only :versioned_formula

# End-of-life on 2028-06-04: https://mariadb.org/about/#maintenance-policy
deprecate! date: "2028-06-04", because: :unsupported
# From https://mariadb.org/about/#maintenance-policy:
# > Critical security fixes will be provided as source code releases only and
# > on a best effort basis for 2 additional years beyond Community maintenance
# > LTS level
Comment on lines +32 to +34
Copy link
Copy Markdown
Member

@daeho-ro daeho-ro Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the reason to keep 2 more years, upstream already specified the date of EOL.

Copy link
Copy Markdown
Contributor Author

@ottok ottok Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Upstream defined the date for EOL as 2030-06-04 for MariaDB 11.8, and that is the whole point why I submitted this PR. The date in Homebrew is currently wrong as the last binary release date was used, not the actual date for how long Homebrew, Linux distros and anyone else building from sources has.

Copy link
Copy Markdown
Member

@SMillerDev SMillerDev Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"best effort" doesn't really sound the same as "supported". But the deprecation date should probably be whenever they stop doing normal releases, with the disable! being this date when it is fully EOL.

Copy link
Copy Markdown
Contributor Author

@ottok ottok Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In their vocabulary "supported" means when they publish binaries, which does not affect Homebrew. For Homebrew the relevant date is how long there will be updates in the source code, which is until 2030-06-04.

Copy link
Copy Markdown
Member

@SMillerDev SMillerDev Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will they also still tag releases in the source until then?

Copy link
Copy Markdown

@vuvova vuvova Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

deprecate! date: "2030-06-04", because: :unsupported

depends_on "bison" => :build
depends_on "cmake" => :build
Expand Down
Loading