Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 29, 2024

Attempting to reproduce failure:

   ◯ Storage: Configure a security rules file for Cloud Storage
  (Move up and down to reveal more choices)
  Error: firebase-cli: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 1
    Actual: nil

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-bottles Merge without publishing bottles labels Oct 29, 2024
@github-actions github-actions bot added the nodejs Node or npm use is a significant feature of the PR or issue label Oct 29, 2024
@cho-m cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Oct 29, 2024
@cho-m cho-m force-pushed the firebase-cli-test branch 2 times, most recently from 7744e54 to c2ca5e5 Compare October 29, 2024 14:04
@cho-m cho-m removed the CI-linux-self-hosted Build on Linux self-hosted runner label Oct 29, 2024
@cho-m cho-m changed the title firebase-cli: reproduce test failure firebase-cli: update test for self-hosted linux Oct 29, 2024
@cho-m cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Oct 29, 2024
@cho-m cho-m force-pushed the firebase-cli-test branch from c2ca5e5 to 5365f2c Compare October 29, 2024 14:15
@cho-m cho-m mentioned this pull request Oct 29, 2024
12 tasks
@cho-m cho-m marked this pull request as ready for review October 29, 2024 14:26
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Oct 29, 2024
@carlocab
Copy link
Member

nil exit status usually means a crash.

@cho-m
Copy link
Member Author

cho-m commented Oct 29, 2024

nil exit status usually means a crash.

Probably, but would like to get a workaround to avoid having to continue merging other PRs with red CI (only reason this formula might run on self-hosted is due to dep tests).

As I recall, this has been the behavior for a while but we've just ignored it as part of dep tests and just merged the failed runs.

Would need someone interested in figuring out exact reason. I don't think we've seen any user reports of issue. It could just be issue running in GCP.


Specifically, would like these merged before I start the final run for #193114 where some dep tests fail only due to running on self-hosted.

Plan to kick it off in an hour or so.

@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit 7c80800 Oct 29, 2024
23 checks passed
@BrewTestBot BrewTestBot deleted the firebase-cli-test branch October 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants