Skip to content

akamai 0.2.0 #16552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

akamai 0.2.0 #16552

wants to merge 1 commit into from

Conversation

kporowski
Copy link

Created with brew bump-formula-pr.

@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 9, 2017

@dshafik It looks like c17627c5ee10ed6e9ef92dafb8d5b46160484e0d is no longer a valid revision for the https://github.com/src-d/go-git repository. It still exists on GitHub but appears to be a dangling commit.

Failed to set version on github.com/src-d/go-git to c17627c5ee10ed6e9ef92dafb8d5b46160484e0d: Unable to update checked out version

@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 9, 2017

@kporowski I believe the command in the test needs to change from akamai get purge to akamai install purge.

@dshafik
Copy link
Contributor

dshafik commented Aug 9, 2017

I too ran into this while working on 0.3.0; the change to install is in 0.2.0 for which the formula hasn't been updated yet. I'll release an updated 0.2.1 and update the formula today.

Can't say as I've ever experienced a commit going away like this, obviously a history rewrite and a force push.

@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 9, 2017

Can't say as I've ever experienced a commit going away like this, obviously a history rewrite and a force push.

Yeah it's not good. I'm not sure there's a great way to avoid this happening without committing a vendor/ directory to your own repository, or creating a release tarball with the full set of resources.

@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 9, 2017

@kporowski passing on this PR for now since it doesn't build and 0.2.1 will be out soon. Thank you for the PR nonetheless!

@ilovezfs ilovezfs closed this Aug 9, 2017
@kporowski
Copy link
Author

@dshafik I have figured the same thing out and were going to update cli later today. Just wanted to investigate why that commit was missing. You can find more info here: src-d/go-git#535 and src-d/go-git#504
@ilovezfs I was not expecting brew bump-formula-pr to proceed without a successful local build. I would need to do some more reading it seems :)

dshafik added a commit to akamai/cli that referenced this pull request Aug 10, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
@kporowski kporowski deleted the akamai-0.2.0 branch November 18, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants