Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 16, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Nov 16, 2023
@github-actions github-actions bot added the boost Boost use is a significant feature of the PR or issue label Nov 16, 2023
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 16, 2023
@SMillerDev
Copy link
Member

ARM builds are not happy

  /tmp/clblas-20231115-4205-vsb8n1/clBLAS-2.12/src/library/blas/gens/gemv.c:484:48: error: call to undeclared library function 'abs' with type 'int (int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
              kargs->offCY += (kargs->K - off) * abs(kargs->ldc.Vector);
                                                 ^
  /tmp/clblas-20231115-4205-vsb8n1/clBLAS-2.12/src/library/blas/gens/gemv.c:484:48: note: include the header <stdlib.h> or explicitly provide a declaration for 'abs'
  1 error generated.
  /tmp/clblas-20231115-4205-vsb8n1/clBLAS-2.12/src/library/blas/gens/symv.c:955:29: error: call to undeclared library function 'abs' with type 'int (int)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                              abs(kargs->ldc.Vector);
                              ^
  /tmp/clblas-20231115-4205-vsb8n1/clBLAS-2.12/src/library/blas/gens/symv.c:955:29: note: include the header <stdlib.h> or explicitly provide a declaration for 'abs'
  1 error generated.

@Bo98
Copy link
Member

Bo98 commented Nov 16, 2023

Missing a #include <stdlib.h> which x86_64 implicitly is picking up from OpenCL's SSE intrinsics includes

Copy link
Contributor

github-actions bot commented Dec 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 7, 2023
@SMillerDev
Copy link
Member

@cho-m maybe use my PR as an inline patch?

@github-actions github-actions bot removed the stale No recent activity label Dec 11, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 12, 2023
Merged via the queue into Homebrew:master with commit df5d5f2 Dec 12, 2023
@cho-m cho-m deleted the clblas-mac-py branch March 1, 2024 16:14
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants