tcl-tk: move all headers to subdirectory #124056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just by installing to `include/tcl-tk` instead of `include`, we solve several issues when removing the "keg-only" attribute: * pathname clashes with `xorgproto` * `brew audit` complaints about shadowing macOS Tcl/Tk's own headers * `tclConfig.sh` and `tkConfig.sh` are generated with the correct include path, so everything that depends on Tcl/Tk should still build correctly Addresses https://github.com/orgs/Homebrew/discussions/4264.
ZhongRuoyu
approved these changes
Feb 23, 2023
|
🤖 A scheduled task has triggered a merge. |
simonjwright
added a commit
to simonjwright/tcladashell
that referenced
this pull request
Feb 24, 2023
Prior to Homebrew/homebrew-core#124056, tcl-tk was "keg-only" which meant it couldn't be found on the standard include path ($HOMEBREW_PREFIX/include); however, you can always find an installed package in $HOMEBREW_PREFIX/opt. The change above moves the tcl-tk includes down a level, so here we include both; one of them should work! * tcl_tk_options.gpr (C_Compiler_Switches): on macos, provide both possible include paths. * alire.toml (version): update to 8.7.2.
simonjwright
added a commit
to simonjwright/tcladashell
that referenced
this pull request
Feb 24, 2023
Prior to Homebrew/homebrew-core#124056, tcl-tk was "keg-only" which meant it couldn't be found on the standard include path ($HOMEBREW_PREFIX/include); however, you can always find an installed package in $HOMEBREW_PREFIX/opt. The change above moves the tcl-tk includes down a level, so here we include both; one of them should work! * tcl_tk_options.gpr (C_Compiler_Switches): on macos, provide both possible include paths. * alire.toml (version): update to 8.7.2. * config/: removed. It gets regenerated on fetch or update.
ZhongRuoyu
added a commit
to Porkepix/homebrew-core
that referenced
this pull request
Mar 8, 2023
The location of `tcl-tk` headers was changed in Homebrew#124056.
Closed
BrewTestBot
pushed a commit
that referenced
this pull request
Mar 8, 2023
* x3270 4.2ga9 * x3270: fix `tcl-tk` includes The location of `tcl-tk` headers was changed in #124056. Closes #124903. Co-authored-by: Ruoyu Zhong <[email protected]> Signed-off-by: Patrick Linnane <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
ZhongRuoyu
added a commit
to chenrui333/homebrew-core
that referenced
this pull request
Mar 16, 2023
The location of `tcl-tk` headers was changed in Homebrew#124056.
BrewTestBot
pushed a commit
that referenced
this pull request
Mar 17, 2023
* opencascade 7.7.0 * opencascade: fix build * opencascade: fix `tcl-tk` includes The location of `tcl-tk` headers was changed in #124056. Signed-off-by: Rui Chen <[email protected]> Co-authored-by: Ruoyu Zhong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just by installing to
include/tcl-tkinstead ofinclude, we solve several issues when removing the "keg-only" attribute:xorgprotobrew auditcomplaints about shadowing macOS Tcl/Tk's own headerstclConfig.shandtkConfig.share generated with the correct include path, so everything that depends on Tcl/Tk should still build correctlyAddresses https://github.com/orgs/Homebrew/discussions/4264.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?