This repository was archived by the owner on Apr 22, 2025. It is now read-only.
bundle/commands/exec: improve PATH handling. #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
improve_paths
branch
2 times, most recently
from
7daa4ad to
aa2d761
Compare
carlocab
approved these changes
Mar 13, 2025
MikeMcQuaid
force-pushed
the
improve_paths
branch
from
aa2d761 to
8ed129c
Compare
- don't add `pkg-config` to the PATH on macOS, it's not needed as a shim already exists in Homebrew on macOS for this and we're overriding it here - replace `pkg-config` references with `pkgconf` which we use instead now to avoid unnecessary redirection - any package with a version specified in an environment variable should be prepended to PATH-like environment variables, not appended
MikeMcQuaid
force-pushed
the
improve_paths
branch
from
8ed129c to
aa97115
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg-configto the PATH on macOS, it's not needed as a shim already exists in Homebrew on macOS for this and we're overriding it herepkg-configreferences withpkgconfwhich we use instead now to avoid unnecessary redirection