This repository was archived by the owner on Apr 22, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 297
Implement brew bundle remove
#1640
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# typed: true | ||
# frozen_string_literal: true | ||
|
||
module Bundle | ||
module Commands | ||
module Remove | ||
module_function | ||
|
||
def run(*args, type:, global:, file:) | ||
Bundle::Remover.remove(*args, type:, global:, file:) | ||
end | ||
end | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# typed: true | ||
# frozen_string_literal: true | ||
|
||
module Bundle | ||
module Remover | ||
module_function | ||
|
||
def remove(*args, type:, global:, file:) | ||
brewfile = Brewfile.read(global:, file:) | ||
content = brewfile.input.split("\n") | ||
entry_type = type.to_s if type != :none | ||
escaped_args = args.map { |arg| Regexp.escape(arg) } | ||
content = content.grep_v(/#{entry_type}(\s+|\(\s*)"(#{escaped_args.join("|")})"/) | ||
.join("\n") << "\n" | ||
path = Dumper.brewfile_path(global:, file:) | ||
|
||
Dumper.write_file path, content | ||
carlocab marked this conversation as resolved.
Show resolved
Hide resolved
|
||
end | ||
carlocab marked this conversation as resolved.
Show resolved
Hide resolved
|
||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# frozen_string_literal: true | ||
|
||
require "cask/cask_loader" | ||
|
||
describe Bundle::Commands::Remove do | ||
subject(:remove) do | ||
described_class.run(*args, type:, global:, file:) | ||
end | ||
|
||
before { File.write(file, "brew \"hello\"\n") } | ||
after { FileUtils.rm_f file } | ||
|
||
let(:global) { false } | ||
|
||
context "when called with a valid formula" do | ||
let(:args) { ["hello"] } | ||
let(:type) { :brew } | ||
let(:file) { "/tmp/some_random_brewfile#{Random.rand(2 ** 16)}" } | ||
|
||
it "removes entries from the given Brewfile" do | ||
expect { remove }.not_to raise_error | ||
expect(File.read(file)).not_to include("#{type} \"#{args.first}\"") | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.