Skip to content

Conversation

chenrui333
Copy link
Member

remove obsolete build patches

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wonder if we can find a way to automate this in the future.

@chenrui333 chenrui333 merged commit d448a2b into main Jun 10, 2025
5 checks passed
@chenrui333 chenrui333 deleted the remove-outdated-patches-20250610 branch June 10, 2025 21:00
@chenrui333
Copy link
Member Author

Thanks! Wonder if we can find a way to automate this in the future.

yeah, we should, the only false negative is proctools (other than it, it can be just a simple grep and check)

@Bo98
Copy link
Member

Bo98 commented Jun 10, 2025

@chenrui333
Copy link
Member Author

Seems like some of these are used? e.g. https://github.com/Homebrew/homebrew-core/blob/d6a4adc8498c1b785751b3941636f8442e877f6d/Formula/i/irrlicht.rb#L48-L58

indeed, also uncover some other being referenced patches (seems like the current script is not quite reliable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants