fix: rescue FormulaSpecificationError in Formula.all#21796
Merged
MikeMcQuaid merged 2 commits intoHomebrew:mainfrom Mar 22, 2026
Merged
fix: rescue FormulaSpecificationError in Formula.all#21796MikeMcQuaid merged 2 commits intoHomebrew:mainfrom
MikeMcQuaid merged 2 commits intoHomebrew:mainfrom
Conversation
When a tap formula has no URL, `determine_active_spec` raises `FormulaSpecificationError`. `Formula.all` already rescues `FormulaUnavailableError` and `FormulaUnreadableError` to prevent a single broken formula from crashing commands like `brew search --eval-all --desc`, but `FormulaSpecificationError` was missing from the rescue clause. Closes Homebrew#21794
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

brew lgtm(style, typechecking and tests) with your changes locally?brew tests --only formula— all passing).What does this PR do?
When a tap formula has no URL,
determine_active_specraisesFormulaSpecificationError.Formula.allalready rescuesFormulaUnavailableErrorandFormulaUnreadableErrorto prevent one broken formula from crashing commands likebrew search --eval-all --desc, butFormulaSpecificationErrorwas missing from the rescue clause.This adds
FormulaSpecificationErrorto the rescue so the broken formula is logged as a warning instead of crashing the entire search.Why should this be included?
A single broken tap formula (with no URL) shouldn't take down
brew search --eval-all --descfor the user's entire formula catalog.Closes #21794