Skip to content

bump: use semicolon skip messages delimiter#21714

Merged
MikeMcQuaid merged 1 commit intomainfrom
bump-use-semicolon-skip-messages-delimiter
Mar 11, 2026
Merged

bump: use semicolon skip messages delimiter#21714
MikeMcQuaid merged 1 commit intomainfrom
bump-use-semicolon-skip-messages-delimiter

Conversation

@samford
Copy link
Copy Markdown
Member

@samford samford commented Mar 11, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

We recently updated Livecheck::SkipConditions.print_skip_information to join messages using a semicolon, so this updates the similar logic in brew bump to use the same delimiter.

This is a follow-up to #21708, where I requested this change in review.

We recently updated `Livecheck::SkipConditions.print_skip_information`
to join messages using a semicolon, so this updates the similar logic
in `brew bump` to use the same delimiter.
Copilot AI review requested due to automatic review settings March 11, 2026 16:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tweaks brew bump’s livecheck skip-status output formatting to use a semicolon-separated list when multiple skip messages are present, aligning it with existing livecheck skip messaging conventions.

Changes:

  • Change livecheck skip message joining from ", " to "; " in Homebrew::DevCmd::Bump#livecheck_result.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 4135bad Mar 11, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the bump-use-semicolon-skip-messages-delimiter branch March 11, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants