test_bot: avoid deferring when only running dependent tests#21672
Merged
MikeMcQuaid merged 1 commit intomainfrom Mar 6, 2026
Merged
test_bot: avoid deferring when only running dependent tests#21672MikeMcQuaid merged 1 commit intomainfrom
MikeMcQuaid merged 1 commit intomainfrom
Conversation
This avoids issue of accidentally skipping some dependent tests. For example, when `lua` and `luarocks` were modified in same PR, some direct dependents like `luacheck` got skipped as: 1. `lua` dependents were deferred to be handled by `luarocks` 2. `luarocks` dependents were skipped as build-only dependency The defer logic is still needed if test-bot runs both formulae and dependent tests together to make sure bottles exist before tests.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts brew test-bot dependent-selection behavior to avoid incorrectly deferring/skipping dependents when running only the dependents phase, preventing missed dependent tests in multi-formula PRs.
Changes:
- Skip the “defer dependents until later” filtering when
--only-formulae-dependentsis used. - Preserve existing deferral behavior for runs that include building formulae alongside dependent testing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlocab
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This avoids issue of accidentally skipping some dependent tests.
For example, when
luaandluarockswere modified in same PR, some direct dependents likeluacheckgot skipped as:luadependents were deferred to be handled byluarocksluarocksdependents were skipped as build-only dependencyThe defer logic is still needed if test-bot runs both formulae and dependent tests together to make sure bottles exist before tests.