Skip to content

fix cargo features type signature#21610

Merged
MikeMcQuaid merged 1 commit intomainfrom
cargo-features-fix
Feb 22, 2026
Merged

fix cargo features type signature#21610
MikeMcQuaid merged 1 commit intomainfrom
cargo-features-fix

Conversation

@daeho-ro
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Type fix, I was originally added Symbol type but it is no longer exist.

Copilot AI review requested due to automatic review settings February 22, 2026 11:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Sorbet type signature for the public Formula#std_cargo_args helper to change what types are accepted for the features: parameter.

Changes:

  • Adjust std_cargo_args’s features: Sorbet signature to no longer include Symbol.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 22, 2026
Merged via the queue into main with commit 5a94ef2 Feb 22, 2026
41 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cargo-features-fix branch February 22, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants