Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request changes the mark_as_installed_on_request! method to use brew tab --installed-on-request command instead of directly writing to tab files. This approach ensures proper privilege escalation when using external brew wrappers that restrict brew bundle permissions due to user code execution.
Changes:
- Refactored from individual tab file writes to a batched
brew tabcommand invocation - Changed from
.eachiteration with immediate writes to.filter_mapcollecting formula names for batch processing - Added explanatory comment about wrapper privilege handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
reviewed
Jan 16, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Could this instead go through the wrapper only if the write fails given it's a slowdown?
Member
Author
|
Sure, I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some external brew wrappers treat
brew bundlewith lower permissions due to its execution of user code. In such scenarios, writing to the Homebrew prefix might fail. Running throughbrew tabwill avoid these issues as it will go through the brew wrapper again, and more closely mimic how the rest ofbrew bundleworks (e.g. issuingbrew installcommands).This will be a little slower but will generally only be a one-time operation anyway.