dev-cmd/typecheck: fix Ruby version conflict in sigil bump#21394
Merged
dev-cmd/typecheck: fix Ruby version conflict in sigil bump#21394
Conversation
Member
Author
|
EDIT: The issue is that the Sorbet workflow isn't really designed for testing changes. That was a misunderstanding on my part. This works as intended. |
80ae2f5 to
efea907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?When running
brew typecheck --update --suggest-typed, spoom's exec method usesBundler.with_unbundled_envwhich strips environment variables that ensure Homebrew's portable Ruby is used. This caused#!/usr/bin/env rubyin thesrbwrapper script to resolve to the system Ruby 2.6 on macOS GitHub runners.Lets use the native sorbet binary from sorbet-static directly instead.
Seen in https://github.com/Homebrew/brew/actions/runs/20927488069/job/60129300539: