Skip to content

dev-cmd/typecheck: fix Ruby version conflict in sigil bump#21394

Merged
p-linnane merged 1 commit intomainfrom
typecheck-version-conflict
Jan 12, 2026
Merged

dev-cmd/typecheck: fix Ruby version conflict in sigil bump#21394
p-linnane merged 1 commit intomainfrom
typecheck-version-conflict

Conversation

@p-linnane
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

When running brew typecheck --update --suggest-typed, spoom's exec method uses Bundler.with_unbundled_env which strips environment variables that ensure Homebrew's portable Ruby is used. This caused #!/usr/bin/env ruby in the srb wrapper script to resolve to the system Ruby 2.6 on macOS GitHub runners.

Lets use the native sorbet binary from sorbet-static directly instead.

Seen in https://github.com/Homebrew/brew/actions/runs/20927488069/job/60129300539:

==> Checking if we can bump Sorbet `typed` sigils...
Checking files...
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/bundler/lockfile_parser.rb:108:in warn_for_outdated_bundler_version': You must use Bundler 2 or greater with this lockfile. (Bundler::LockfileError)

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@p-linnane
Copy link
Copy Markdown
Member Author

p-linnane commented Jan 12, 2026

Hmmm. This might not be complete. Let me debug more.

https://github.com/Homebrew/brew/actions/runs/20927880452/job/60130701821

EDIT: The issue is that the Sorbet workflow isn't really designed for testing changes. That was a misunderstanding on my part. This works as intended.

@p-linnane p-linnane force-pushed the typecheck-version-conflict branch from 80ae2f5 to efea907 Compare January 12, 2026 17:37
@p-linnane p-linnane enabled auto-merge January 12, 2026 17:38
@p-linnane p-linnane added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit 9183cc7 Jan 12, 2026
39 checks passed
@p-linnane p-linnane deleted the typecheck-version-conflict branch January 12, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants