Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 17, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Currently some tests require ENV.clang or ENV.method(DevelopmentTools.default_compiler).call to bypass the llvm_clang compiler selector can pick since standard environment doesn't have this in PATH.

@cho-m
Copy link
Member Author

cho-m commented Sep 17, 2025

I may want to add the LLVM header shim to standard environment before merge to work around same issue as superenv. So:

  • Move shims/mac/super/include --> shims/mac/shared/include
  • Maybe use CPLUS_INCLUDE_PATH to inject it (not sure if other flags will be used automatically).

@MikeMcQuaid
Copy link
Member

@cho-m both sound sensible to me

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit ee62d64 Sep 17, 2025
36 of 37 checks passed
@MikeMcQuaid MikeMcQuaid deleted the std-llvm_clang branch September 17, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants