Skip to content

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We should bump HOMEBREW_MACOS_OLDEST_SUPPORTED first and make sure
that bump goes out into a release tag before dropping CI in
Homebrew/core. Otherwise, we end up with users getting errors about
missing bottles. See, for example, Homebrew/homebrew-core#240857.

We've made it very hard for users on OS versions newer than
HOMEBREW_MACOS_OLDEST_SUPPORTED to not use bottles (because only
bottles are supported), but that design assumes we have been building
bottles for them. We should therefore make sure that users we stop
building bottles for are always on a version older than
HOMEBREW_MACOS_OLDEST_SUPPORTED.

…from CI

We should bump `HOMEBREW_MACOS_OLDEST_SUPPORTED` first and make sure
that bump goes out into a release tag before dropping CI in
Homebrew/core. Otherwise, we end up with users getting errors about
missing bottles. See, for example, Homebrew/homebrew-core#240857.

We've made it very hard for users on OS versions newer than
`HOMEBREW_MACOS_OLDEST_SUPPORTED` to *not* use bottles (because only
bottles are supported), but that design assumes we have been building
bottles for them. We should therefore make sure that users we stop
building bottles for are always on a version older than
`HOMEBREW_MACOS_OLDEST_SUPPORTED`.
@carlocab carlocab requested a review from Bo98 September 17, 2025 06:41
@carlocab carlocab self-assigned this Sep 17, 2025
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@carlocab carlocab added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit 9130759 Sep 17, 2025
36 checks passed
@carlocab carlocab deleted the runner-matrix-oldest-supported branch September 17, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants