test/github_runner_matrix: prevent dropping supported macOS versions from CI #20714
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?We should bump
HOMEBREW_MACOS_OLDEST_SUPPORTED
first and make surethat bump goes out into a release tag before dropping CI in
Homebrew/core. Otherwise, we end up with users getting errors about
missing bottles. See, for example, Homebrew/homebrew-core#240857.
We've made it very hard for users on OS versions newer than
HOMEBREW_MACOS_OLDEST_SUPPORTED
to not use bottles (because onlybottles are supported), but that design assumes we have been building
bottles for them. We should therefore make sure that users we stop
building bottles for are always on a version older than
HOMEBREW_MACOS_OLDEST_SUPPORTED
.