Visual and Navigation improvements #14
Conversation
Add 2016 and 2017 favicons See #3
| background: -webkit-linear-gradient(45deg, rgb(24, 103, 189) 0%, rgb(117, 173, 225) 100%); /* Chrome10-25,Safari5.1-6 */ | ||
| background: linear-gradient(45deg, rgb(24, 103, 189) 0%, rgb(117, 173, 225) 100%); /* W3C, IE10+, FF16+, Chrome26+, Opera12+, Safari7+ */ | ||
| background: #0081cb; /* Old browsers */ | ||
| background: -moz-linear-gradient(45deg, #0081cb 0%, #00b0ff 100%); /* FF3.6-15 */ |
There was a problem hiding this comment.
What about changing #00b0ff to #0081cb here as well? I find the first option to be pretty neon-ish, the latter rather looks like the ocean and has something calming to it. Ocean might fit well as a theme here for the environment. :) But either way is fine.
There was a problem hiding this comment.
this is a gradient - do you mean changing the first color #00b0ff to the latter one as well, pretty much eliminating the gradient?
There was a problem hiding this comment.
Oh, I didn't see that it matches the first color 😅
Let's keep it as is then.
2016/index.html
Outdated
| @@ -71,7 +69,7 @@ | |||
| <!--<a href="http://mlh.io" target="_blank" class="banner mlh"></a>--> | |||
| <div class="row"> | |||
| <div class="col-md-8 col-md-offset-2 text-center"> | |||
| <a href="https://2016.hackhpi.org/" class="logo"></a> | |||
| <a href="https://hackhpi.org/2016" class="logo"></a> | |||
There was a problem hiding this comment.
Couldn't we just let these types of links point to index.html as we're not forwarding hackhpi.org requests yet to the GitHub Pages URL and we would use relative links? Or is that considered bad practice?
There was a problem hiding this comment.
thought about that as well, could just set the href to # - in react apps however that throws a warning, might be considered bad practice. Don't know about that for sure though.
|
I'm going to move the |
Also some small difference in wording on the imprint page.
Added more appealing colors.
Moved
hhpi2017.htmlto/2017/index.htmland 2016 respectively, to allow for imprint and press to use the same locations. Also allows for nicer URL readability.Added 2016 and 2017 favicons.
Closes #11, #12, #1, #2, #3.