Skip to content

Wrapper script / interface for eCLM static file generator#71

Draft
jjokella wants to merge 5 commits intomainfrom
dev-interface
Draft

Wrapper script / interface for eCLM static file generator#71
jjokella wants to merge 5 commits intomainfrom
dev-interface

Conversation

@jjokella
Copy link
Copy Markdown
Collaborator

@jjokella jjokella commented Mar 5, 2026

The script run_static_file_generator.sh allows to execute the whole workflow of the eCLM static file generator in one command (as of now, only for a single site case).

jjokella and others added 2 commits February 12, 2026 17:39
for now: tailored towards creating a single site case

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`--account` and `--partition` passed as command line arguments and
changed in SLURM script.

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@mvhulten mvhulten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added code looks good, but I have not tested it.

Latest patch of mine is not really related (but see #19). It effectively reverts a few changed introduced with the documentation restructuring back to my past efforts. I have not tested it, but am confident each of these changes are correct.
I have undone this, because it was unintentionally fixing "old documentation" and it is unrelated.

@mvhulten mvhulten marked this pull request as draft March 6, 2026 08:03
@s-poll
Copy link
Copy Markdown
Member

s-poll commented Mar 6, 2026

Thanks for the script. I think that make it very easy to generate surfdata :) Just a slide remark: I think it should be mentioned that it only works for rectilinear grids or (even better) also let the script support the other grid types (curvilinear, triangular).

@mvhulten
Copy link
Copy Markdown
Collaborator

mvhulten commented Mar 6, 2026

In principle the user only needs to give the grid name (why is the option not just --grid or so?) and then the type of grid and what needs to be done (conditionals) by can be determined by the script.

If the script were to do only one thing, it should be the icosahedral case, in my opinion. Best is indeed all three grid types.

jjokella and others added 2 commits March 12, 2026 13:06
Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jjokella
Copy link
Copy Markdown
Collaborator Author

I adapted the wrapper script and generated a documentation:

Also, the NCL script for curvilinear scripts was adapted for it to take inputs instead of hard-coded values. From my first check, these changes make sense.

Maybe you can try a typical small curvilinear / icosahedral workflow with this new version of the script.

@jjokella jjokella requested review from mvhulten and s-poll March 12, 2026 12:44
@mvhulten
Copy link
Copy Markdown
Collaborator

I have a full-week workshop and am unsure if I can this week give the thorough review it deserves. I can do the review next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants