Fix KaTeX chemistry formula rendering (\ce command) not working#2443
Merged
danielaskdd merged 4 commits intoHKUDS:mainfrom Dec 1, 2025
Merged
Fix KaTeX chemistry formula rendering (\ce command) not working#2443danielaskdd merged 4 commits intoHKUDS:mainfrom
danielaskdd merged 4 commits intoHKUDS:mainfrom
Conversation
• Move mhchem/copy-tex to main.tsx • Add katex to Vite dedupe config • Remove dynamic extension loading • Ensure extensions available globally • Fix chemistry formula rendering
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KaTeX chemistry formula rendering (\ce command) not working
Summary
This PR fixes KaTeX chemistry formula rendering in the Web UI chat messages. The
\ce{}command (from mhchem extension) was displaying as red error text instead of properly rendered chemistry formulas.Problem
When users input chemistry formulas using KaTeX's
\ce{}syntax (e.g.,$$\ce{NH3 + HCl -> NH4Cl}$$), the\cecommand was rendered in red as an unrecognized command, even though the mhchem extension was being imported.Root Cause:
rehype-katexhaskatexas a direct dependency, not a peer dependency. This caused Vite to create two separate KaTeX instances - one for the project and one bundled insiderehype-katex. The mhchem extension was registered to the project's KaTeX instance, butrehype-katexused its own internal instance where mhchem was not registered.Solution
main.tsx) instead of dynamically in componentuseEffectvite.config.ts) to force all modules to use the same KaTeX instanceChanges
lightrag_webui/src/main.tsx- Static imports forkatex/contrib/mhchemandkatex/contrib/copy-texlightrag_webui/vite.config.ts- Addresolve.dedupe: ['katex']to ensure single KaTeX instancelightrag_webui/src/types/katex.d.ts- Add module declarations for KaTeX contrib moduleslightrag_webui/src/components/retrieval/ChatMessage.tsx- Cleanup redundant dynamic importsNew Features
\ce{}command now works (e.g.,$$\ce{2H2 + O2 -> 2H2O}$$)\pu{}command now works (e.g.,$$\pu{123 kJ/mol}$$)Testing
After restart dev server (
bun run dev) and hard refresh:\ce{}should render correctly