Refact: Enhance DOCLING integration with lazy loading and macOS safeguards#2352
Merged
danielaskdd merged 2 commits intoHKUDS:mainfrom Nov 13, 2025
Merged
Conversation
- Add --docling CLI flag for easier setup - Add numpy version constraints - Exclude docling on macOS (fork-safety)
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refact: Enhance DOCLING integration with lazy loading and macOS safeguards
🎯 Summary
Improve DOCLING document loading engine integration with enhanced macOS compatibility and multi-worker Gunicorn support. This PR addresses PyTorch fork-safety issues on macOS and implements better configuration management for the DOCLING engine.
🔧 Changes
1. CLI Configuration Enhancement (
lightrag/api/config.py)--doclingCLI flag to enable DOCLING document loading engine2. Lazy Loading Implementation (
lightrag/api/routers/document_routes.py)@lru_cachefunction3. macOS Compatibility Guard (
lightrag/api/run_with_gunicorn.py)--workers 1)4. Platform-Specific Dependencies (
pyproject.toml)docling>=2.0.0,<3.0.0; sys_platform != 'darwin'>=1.24.0,<2.0.0for better stability5. Dependency Lock Updates (
uv.lock)🐛 Problems Solved
✅ Benefits
🧪 Testing Recommendations
--doclingflag on Linux with multi-worker Gunicorn--docling --workers 2📋 Migration Notes
For macOS users:
--workers 1(single worker mode)DOCUMENT_LOADING_ENGINE=DEFAULTon macOSFor all users:
--doclingCLI flag available as alternative toDOCUMENT_LOADING_ENGINE=DOCLING