Refact: Implement Lazy Configuration Initialization for API Server#2351
Merged
danielaskdd merged 2 commits intoHKUDS:mainfrom Nov 13, 2025
Merged
Refact: Implement Lazy Configuration Initialization for API Server#2351danielaskdd merged 2 commits intoHKUDS:mainfrom
danielaskdd merged 2 commits intoHKUDS:mainfrom
Conversation
• Add lazy config initialization • Maintain backward compatibility • Support programmatic usage • Add gunicorn dependency • Explicit config in entry points
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refact: Implement Lazy Configuration Initialization for API Server
Overview
This PR introduces a lazy initialization pattern for the LightRAG API server configuration, improving flexibility for programmatic usage while maintaining full backward compatibility with existing code.
Motivation
Previously, the API server configuration was initialized eagerly at module import time, which:
Changes
Core Implementation
lightrag/api/config.py)initialize_config()function for explicit initialization controlget_config()function for lazy auto-initialization_GlobalArgsProxyclass to maintain backward compatibilityAPI Integration
lightrag/api/lightrag_server.py,lightrag/api/run_with_gunicorn.py)initialize_config()calls inmain()functionsDependencies
pyproject.toml)gunicornto API dependencies for production-ready WSGI server supportLock File
uv.lockto reflect new dependencyBenefits
Backward Compatibility: Existing code using
from config import global_argscontinues to work without changesProgrammatic Usage: Applications can now initialize LightRAG with custom configurations:
Testing Flexibility: Tests can now initialize with specific configurations without relying on command-line arguments
Control Over Timing: Applications can control exactly when configuration initialization occurs
Technical Details
The implementation uses a proxy pattern:
_GlobalArgsProxyintercepts attribute access to the global configurationparse_args()initialize_config()allows pre-initialization with custom valuesTesting