Remove deprecated response_type parameter from query settings UI#2345
Merged
danielaskdd merged 1 commit intoHKUDS:mainfrom Nov 12, 2025
Merged
Remove deprecated response_type parameter from query settings UI#2345danielaskdd merged 1 commit intoHKUDS:mainfrom
danielaskdd merged 1 commit intoHKUDS:mainfrom
Conversation
- Bump API version to 0254 - Remove response format UI controls - Hard-code response_type in query params - Add migration for version 19 - Clean up settings store structure
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
response_typeParameter from Query Settings UISummary
The query parameter
response_typeis deprecated, as it can no longer effectively control the query output. Output behavior can now be guided through theuser_prompt. In the future, full output customization will be achieved by modifying the prompt templates.This PR removes the
response_typeparameter from the query settings interface and fixes it to "Multiple Paragraphs" for all queries. The parameter is no longer configurable by users through the UI.Changes Made
1. Frontend UI (
lightrag_webui/src/components/retrieval/QuerySettings.tsx)response_typefromdefaultValuesobject2. Query Execution (
lightrag_webui/src/features/RetrievalTesting.tsx)response_type: 'Multiple Paragraphs'in thequeryParamsobject3. Settings Store (
lightrag_webui/src/stores/settings.ts)response_type: 'Multiple Paragraphs'from initialquerySettingsstate18to19response_typefrom localStorageMigration Strategy
The implementation includes automatic migration for existing users:
response_typein localStorage will have it automatically removed on next app loadTesting
Breaking Changes
None - This is a UI-only change. The backend API still accepts
response_typeas an optional parameter, ensuring backward compatibility with other clients.