Refactor: Remove Deprecated Chunk-Based Query Methods and Improve Graph Unit Test#2319
Merged
danielaskdd merged 6 commits intoHKUDS:mainfrom Nov 6, 2025
Merged
Conversation
- Add workspace param to test storage init - Remove get_nodes_by_chunk_ids tests - Remove get_edges_by_chunk_ids tests - Clean up batch operations test function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Remove Deprecated Chunk-Based Query Methods and Improve Graph Unit Test
Overview
This PR removes deprecated chunk-based node/edge retrieval methods from all graph storage implementations and introduces workspace parameter support while improving test infrastructure and code quality.
Key Changes
🗑️ Deprecated Code Removal
get_nodes_by_chunk_ids()- removed from NetworkX, MongoDB, Neo4j, Memgraph, and PostgreSQL implementationsget_edges_by_chunk_ids()- removed from all graph storage backendslightrag/base.py: 51 lineslightrag/kg/memgraph_impl.py: 74 lineslightrag/kg/mongo_impl.py: 39 lineslightrag/kg/neo4j_impl.py: 44 lineslightrag/kg/networkx_impl.py: 28 lineslightrag/kg/postgres_impl.py: 97 lines✨ Graph Unit Test Improvements
Breaking Changes
get_nodes_by_chunk_ids()- Applications should use alternative query methodsget_edges_by_chunk_ids()- Applications should use alternative query methods