Refact: Enhance Property editing UI for KG Nodes#2287
Merged
danielaskdd merged 3 commits intoHKUDS:mainfrom Oct 30, 2025
Merged
Refact: Enhance Property editing UI for KG Nodes#2287danielaskdd merged 3 commits intoHKUDS:mainfrom
danielaskdd merged 3 commits intoHKUDS:mainfrom
Conversation
• Use finalValue for entity_id changes • Keep original value for other props • Fix property update logic
- Move color constants to utils module - Extract resolveNodeColor function - Update node colors on type changes - Simplify hook color logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refact: Enhance Property editing UI for KG Nodes
Overview
This PR fixes multiple issues in the graph visualization UI related to property editing, particularly for
entity_idandentity_typeupdates.Changes
1. Fix Entity Type Update Handling (79a17c3)
Problem: When updating
entity_typeproperty, the graph wasn't using the correct value.Solution:
finalValuefor none entity_id changes to ensure the new ID is properly applied2. Change Node Color According to New Entity Type
Problem: When entity_type was changed, node colors and legend weren't updating in real-time.
Solution:
utils/graphColor.tsmoduleresolveNodeColorfunction for consistent color resolutionuseLightragGraphhook (reduced from 219 lines to more maintainable code)3. Property Edit Dialog Optimization
Problem: Input values weren't consistently trimmed in the property edit dialog.
Solution:
Testing Checklist