Refact: Graceful shutdown and signal handling in Gunicorn Mode#2280
Merged
danielaskdd merged 5 commits intoHKUDS:mainfrom Oct 29, 2025
Merged
Refact: Graceful shutdown and signal handling in Gunicorn Mode#2280danielaskdd merged 5 commits intoHKUDS:mainfrom
danielaskdd merged 5 commits intoHKUDS:mainfrom
Conversation
• Add worker_exit hook in gunicorn config • Add shutdown_manager parameter in finalize_share_data of share_storage • Prevent Manager shutdown in workers • Remove custom signal handlers
• Document UvicornWorker hook limitations • Add GUNICORN_CMD_ARGS cleanup guard • Prevent double cleanup in workers
• Use custom env var for mode detection • Improve Gunicorn mode reliability
• Remove unreliable worker_exit function • Add debug logs for cleanup modes • Move DEBUG_LOCKS to top of file
- Remove bash wrapper script - Update systemd service configuration - Improve process management for gunicorn - Simplify shared storage cleanup logic - Update documentation for deployment
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refact: Graceful shutdown and signal handling in Gunicorn Mode
This branch fixes critical issues with graceful shutdown and signal handling in LightRAG's API server, particularly for systemd service deployments and Gunicorn multi-process setups.
Problem: The original implementation had custom signal handlers that competed with Uvicorn/Gunicorn's built-in signal handling, causing:
Solution: Leverage the framework's built-in mechanisms:
on_exithook in master process for shared resource cleanupThis ensures clean, predictable shutdowns in all deployment scenarios (standalone Uvicorn, Gunicorn multi-process, and systemd service management).
Key Changes
1. Signal Handler Removal
2. Improved Shutdown Logic
LIGHTRAG_GUNICORN_MODEenvironment variableon_exithook3. Systemd Service Configuration
lightrag.service.examplewith proper process management settingsKillMode=processto target main process onlyExecStopwith proper timeout (60s)lightrag-gunicornorlightrag-server4. File Cleanup
lightrag-apiwrapper script (no longer needed)5. Documentation Updates
ExecStartmust directly call the main process (no wrapper scripts)