refactor: port div_ceil from stdlib to avoid unstable features #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1191 +/- ##
===========================================
+ Coverage 85.14% 85.17% +0.02%
===========================================
Files 485 485
Lines 71903 71985 +82
===========================================
+ Hits 61223 61312 +89
+ Misses 10680 10673 -7 |
evenyag
reviewed
Mar 16, 2023
v0y4g3r
reviewed
Mar 16, 2023
sunng87
force-pushed
the
feature/compile-time-on-stable
branch
from
8f80ea7 to
9cece3b
Compare
|
Just ported rust stdlib's impl of |
sunng87
changed the title
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…imeTeam#1191) * refactor: use float div&ceil to avoid unstable features * refactor: port div_ceil from rust stdlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
When using our code base with those repos requires stable toolchains, like vector, unstable features block its compilation. This patch removes replaceable unstable feature in time module.
Checklist
Refer to a related PR or issue link (optional)