feat(examples): add low-level API examples and improve configuration #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zqr10159
commented
May 29, 2025
zqr10159
commented
- Add low-level ingestion and streaming examples
- Implement DbConfig struct for better configuration management
- Update high-level examples to use new configuration utils
- Add db-connection.toml file for database connection settings
…management - Add low-level ingestion and streaming examples - Implement DbConfig struct for better configuration management - Update high-level examples to use new configuration utils - Add db-connection.toml file for database connection settings
|
@sunng87 Hi, please help review it, thanks! |
sunng87
reviewed
May 29, 2025
|
Thank you @zqr10159 ! Please follow the CI reporting and check my minor inline comments. |
Thanks, I will fix them soon. |
- Modify config file format and content: - Rename 'dbconfig' to 'database' - Rename 'db.endpoints' to 'endpoints' - Rename 'db.database' to 'dbname' - Update configuration parsing logic in code - Adjust error handling in Server error variant - Improve code formatting and readability in examples
sunng87
reviewed
May 29, 2025
- Enhance code formatting for better visibility - Use consistent indentation and line breaks
- Remove unnecessary Box usage for String in Server error variant - Simplify Server error variant structure
sunng87
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.