fix(web): center OR separator between standard and social login#667
fix(web): center OR separator between standard and social login#667Harshalyadav wants to merge 1 commit intoGreenstand:mainfrom
Conversation
|
This looks good to me. @dadiorchen Could you please review and merge when ready? |
| "data-test"?: string; | ||
| }; | ||
|
|
||
| const OrDivider = ({ text = "OR", sx, "data-test": dataTest }: OrDividerProps) => { |
There was a problem hiding this comment.
Please update the text to match the style and format from the Figma design.
There was a problem hiding this comment.
@pierrelstan Could you please share the link to Figma design?
There was a problem hiding this comment.
| }} | ||
| data-test={dataTest || "or-divider"} | ||
| > | ||
| <Box sx={{ flex: 1, height: 1, bgcolor: "divider" }} /> |
There was a problem hiding this comment.
Are the horizontal lines needed? The Figma design only shows the "Or" text centered.
There was a problem hiding this comment.
The horizontal lines aren’t required. As per the Figma design, only the “Or” text is shown centered without any divider lines.
There was a problem hiding this comment.
@pierrelstan
Hi! After updating the OR separator to match Figma (centered ‘or’, no lines), the component name OrDivider no longer reflects its behavior. Are you okay with renaming it?
Harshalyadav
force-pushed
the
fix/web-centered-or-divider
branch
from
c807ebe to
a7ec428
Compare
3 participants
Description
This PR fixes a UI alignment issue on both the Login and Signup pages where
the “OR” separator between standard authentication and social authentication
options was not centered, making the layout look visually unbalanced.
The update ensures the “OR” separator is properly centered with a clear visual
divider on both pages, improving visual clarity and user experience.
Fixes: #665
Changes Made
Changes in
appsfolder:WebChanges in
packagesfolder:CoreType of Change
Screenshots
How Has This Been Tested?
Checklist:
Additional Comments
This is a visual-only fix applied consistently across both Login and Signup
pages. No authentication logic or existing functionality is affected.