feat: working sendEmail E2E test with MailHog#620
Open
guillermobermejo wants to merge 1 commit intoGreenstand:mainfrom
Open
feat: working sendEmail E2E test with MailHog#620guillermobermejo wants to merge 1 commit intoGreenstand:mainfrom
guillermobermejo wants to merge 1 commit intoGreenstand:mainfrom
Conversation
Collaborator
Author
|
Sorry for the delay following Tuesday’s meeting. I had to fix a few issues after fetching upstream and rebasing — mainly conflicts in package.json. Everything is now resolved, and I was able to get sendEmail.ts working end-to-end using Nodemailer again, delivering successfully to a local fake SMTP server (MailHog). |
Collaborator
|
@guillermobermejo do you get the gmail setting? So you can use that to finish the e2e test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a working email-sending workflow for the Wallet app by adding a new
sendEmailhelper insidepackages/commonalong with a full end-to-end (E2E) test using a local MailHog SMTP server.The goal is to safely validate outgoing email functionality without sending anything to real user inboxes. This prepares the project for future integration with the organization’s Gmail/Workspace SMTP configuration.
Fixes: #632
Resolves: N/A
Changes Made
Changes in
appsfolderNo app changes included.
Changes in
packagesfolder:packages/commonsendEmail.tshelper using Nodemailer (createTransport(...))packages/common/spec/e2e/sendEmail.spec.tsto verify full email deliveryjest.e2e.config.cjs,tsconfig.jest.json)package.jsonwithtest:e2escriptType of Change
How Has This Been Tested?
The email workflow was validated using a local MailHog SMTP server running inside Docker.
This ensures all outgoing emails are captured locally and nothing is sent externally.
1. Start MailHog locally (Docker)